Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add magic cart and discount routes to skeleton template #1309

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Add magic cart and discount routes to skeleton template #1309

merged 5 commits into from
Sep 19, 2023

Conversation

juanpprieto
Copy link
Contributor

Closes https://github.com/orgs/Shopify/projects/5093?pane=issue&itemId=22777016

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes

blittle
blittle approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and suggestions.

frandiox
frandiox approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is the same tested behavior from demo-store, right?
Just left some comments about JSDocs 👍

templates/skeleton/app/routes/cart.$lines.tsx Show resolved Hide resolved
templates/skeleton/app/routes/cart.$lines.tsx Show resolved Hide resolved
templates/skeleton/app/routes/discount.$code.tsx Show resolved Hide resolved
@juanpprieto juanpprieto merged commit 33ae6ab into main Sep 19, 2023
@juanpprieto juanpprieto deleted the juanpprieto/skeleton-cart-lines-route branch September 19, 2023 19:05
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox approved these changes

@blittle blittle blittle approved these changes

@wizardlyhel wizardlyhel Awaiting requested review from wizardlyhel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanpprieto @blittle @frandiox