Reduce CLI init install size #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM >= 7 installs peerDependencies by default except if they are marked as optional (according to this). Since we don't need certain dependencies in the
initcommand and they are already included in the templates, we can stop installing them at the beginning whennpm create @shopify/hydrogenis called, and install them in the background later together with all the other app deps.@remix-run/devalone is ~119MB so this should hopefully speed up installation times.The best way to test this will be when it's merged by using
npm create @shopify/hydrogen@next. However, you can also test locally by renamingnode_modules/@remix-run/devto a different name and runningh2 init(or other commands to see the error).