Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ladle in Hydrogen React #1247

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Fix ladle in Hydrogen React #1247

merged 1 commit into from
Aug 21, 2023

Conversation

blittle
Copy link
Contributor

@blittle blittle commented Aug 18, 2023

WHY are these changes introduced?

The test helpers are shared between ladle and vitest, so they cannot contain functionality specific to either

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

The test helpers are shared between ladle and vitest, so they cannot contain functionality specific to either
@blittle blittle marked this pull request as ready for review August 18, 2023 17:02
@github-actions
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

@blittle blittle merged commit 4583be9 into 2023-07 Aug 21, 2023
@blittle blittle deleted the bl-fix-ladle branch August 21, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants