add shouldRevalidate export to root loaders #1237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Remix revalidates layouts and routes when the url searchParams are added, removed or changed. This means that all our product page navigations, paginated collection pages and changing product variants were causing the root layout loader to revalidate.
WHAT is this pull request doing?
This PR limits the root loaders to only ever revalidate when a mutation is performed. This includes all cart and account POST/PUT/PATCH requests.
HOW to test your changes?
Console log inside a root loader and navigate into and out of route which include a change in the url. The root loader should only log on first page load and when a mutation e.g add to cart happens.
Checklist