feat(hydrogen-react): include applicable in discountCode in default…
#1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CartFragment The `useCart` hook from hydrogen-react uses the defaultCartFragment if not specified otherwise. Developers, when using discountCodes, will often want to know is the code is valid.
|
Thanks! please add a changeset for |
|
@juanpprieto signed the CLA and added a changeset, let me know if I need to make other changes! |
|
@juanpprieto Hey, I'm seeing errors in the gh actions but can't seem to see the error, anything I need to change? |
yes, I noticed. I'm trying to figure out what's up. You all good, we'll take it from here 🙏🏼 |
|
It's just Oxygen deployment failed to load because this is a external contribute PR - merging |
Closed
juanpprieto
pushed a commit
that referenced
this pull request
Jul 10, 2023
#1040) * feat(hydrogen-react): include `applicable` in discountCode in defaultCartFragment The `useCart` hook from hydrogen-react uses the defaultCartFragment if not specified otherwise. Developers, when using discountCodes, will often want to know is the code is valid.
Merged
FrcPpe
pushed a commit
to FrcPpe/hydrogen
that referenced
this pull request
Aug 13, 2023
Shopify#1040) * feat(hydrogen-react): include `applicable` in discountCode in defaultCartFragment The `useCart` hook from hydrogen-react uses the defaultCartFragment if not specified otherwise. Developers, when using discountCodes, will often want to know is the code is valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…CartFragment
The
useCarthook from hydrogen-react uses the defaultCartFragment if not specified otherwise.Developers, when using discountCodes, often want to know is the code is valid.
Checklist