Improve logs in the login command #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We detected some changes in |
Co-authored-by: Gray Gilmore <[email protected]>
|
@graygilmore @blittle I've updated the OP with new images. Now we only show the loader after pressing a key, so the "press a key" message should be more visible. |
|
Updated to stable cli-kit. Please review 🙌 |
graygilmore
approved these changes
Jun 29, 2023
juanpprieto
pushed a commit
that referenced
this pull request
Jul 10, 2023
* Add login and logout commands * Refactor graphql client and requests, add unit tests * Update shopify-config methods and tests * Update renderErrors to use cli Command * Rework env-pull to call login and remove silent param * Rework link command to call login and remove --shop flag * Update list command to call login and remove --shop flag * Update env-list command to call login and remove --shop flag * Oclif manifest * Cleanup * Rework log replacer * Mute cli-kit auth logs * Fix mock * Update cli-kit version * Add GraphQL schema generator for local development * Use business platform login to render a list of shops * Improve login logs * Merge main branch * Fix tests * Minor changes * Update package-lock * Apply suggestions from code review Co-authored-by: Gray Gilmore <[email protected]> * Change link color * Skip writing config when no directory is passed to login * Improve unit tests * Changesets * Refactor to getUserAccount and add tests * Store shopName and email in local config * Show shopName and email after login * Force prompt during login when not passing --shop flag * Fix tests * Only show loader after pressing a key * Show short version of link in terminal * Update cli-kit version and its deps * Cleanup * Update package-lock * Remove duplicated code chunk --------- Co-authored-by: Gray Gilmore <[email protected]>
FrcPpe
pushed a commit
to FrcPpe/hydrogen
that referenced
this pull request
Aug 13, 2023
* Add login and logout commands * Refactor graphql client and requests, add unit tests * Update shopify-config methods and tests * Update renderErrors to use cli Command * Rework env-pull to call login and remove silent param * Rework link command to call login and remove --shop flag * Update list command to call login and remove --shop flag * Update env-list command to call login and remove --shop flag * Oclif manifest * Cleanup * Rework log replacer * Mute cli-kit auth logs * Fix mock * Update cli-kit version * Add GraphQL schema generator for local development * Use business platform login to render a list of shops * Improve login logs * Merge main branch * Fix tests * Minor changes * Update package-lock * Apply suggestions from code review Co-authored-by: Gray Gilmore <[email protected]> * Change link color * Skip writing config when no directory is passed to login * Improve unit tests * Changesets * Refactor to getUserAccount and add tests * Store shopName and email in local config * Show shopName and email after login * Force prompt during login when not passing --shop flag * Fix tests * Only show loader after pressing a key * Show short version of link in terminal * Update cli-kit version and its deps * Cleanup * Update package-lock * Remove duplicated code chunk --------- Co-authored-by: Gray Gilmore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #1023
Cli-kit does not provide a way to change the logs of the authentication features, and it probably would take a while to refactor that since the logs are added in very deep functions.
For now, this should do the job. It's replacing the default logs with
renderTasksand so on.🎩 :
h2 logout;h2 loginand do the normal flow.h2 logout;h2loginagain but this time open the browser with a keypress and don't login. Return to the terminal and wait for 10 seconds until the timeout happens. Click theOpenlink.Gotchas:
First screen:
After pressing a key:
After timeout:
After successful login and selecting 1 shop:
Checklist