Add login and logout commands
#1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
5 tasks
graygilmore
reviewed
Jun 22, 2023
| [ | ||
| 'Run', | ||
| {command: `${cliCommand} link`}, | ||
| 'to link your store to this project.', |
There was a problem hiding this comment.
Suggested change
| 'to link your store to this project.', | |
| 'to link a Hydrogen storefront to this project.', |
maybe clearer?
| @@ -21,14 +21,6 @@ export const commonFlags = { | |||
| env: 'SHOPIFY_HYDROGEN_FLAG_FORCE', | |||
| char: 'f', | |||
| }), | |||
| shop: Flags.string({ | |||
| message: outputContent`Run ${outputToken.genericShellCommand( | ||
| `npx shopify hydrogen link`, | ||
| )}?`.value, | ||
| message: ['Run', {command: `${cliCommand} link`}, '?'], |
There was a problem hiding this comment.
thanks for fixing this formatting ❤️
| [ | ||
| ([first]) => | ||
| typeof first === 'string' && | ||
| (first.includes('Shopify Partners') || first.includes('Logged in')), |
There was a problem hiding this comment.
It showing "Shopify Partners" has annoyed me, too. I wonder if we should fix this upstream in cli-kit.
There was a problem hiding this comment.
Yeah, it's just that it's hardcoded in a deep function so I think it would be hard for them to make it flexible -- I assume "Shopify Partners" is correct for most of the other CLIs 🤔
graygilmore
approved these changes
Jun 22, 2023
graygilmore
approved these changes
Jun 26, 2023
Closed
juanpprieto
pushed a commit
that referenced
this pull request
Jul 10, 2023
* Add login and logout commands * Refactor graphql client and requests, add unit tests * Update shopify-config methods and tests * Update renderErrors to use cli Command * Rework env-pull to call login and remove silent param * Rework link command to call login and remove --shop flag * Update list command to call login and remove --shop flag * Update env-list command to call login and remove --shop flag * Oclif manifest * Cleanup * Rework log replacer * Mute cli-kit auth logs * Fix mock * Merge main branch * Fix tests * Minor changes * Update package-lock * Skip writing config when no directory is passed to login * Improve unit tests * Changesets
Merged
FrcPpe
pushed a commit
to FrcPpe/hydrogen
that referenced
this pull request
Aug 13, 2023
* Add login and logout commands * Refactor graphql client and requests, add unit tests * Update shopify-config methods and tests * Update renderErrors to use cli Command * Rework env-pull to call login and remove silent param * Rework link command to call login and remove --shop flag * Update list command to call login and remove --shop flag * Update env-list command to call login and remove --shop flag * Oclif manifest * Cleanup * Rework log replacer * Mute cli-kit auth logs * Fix mock * Merge main branch * Fix tests * Minor changes * Update package-lock * Skip writing config when no directory is passed to login * Improve unit tests * Changesets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Shopify/core-issues/issues/56397
WHY are these changes introduced?
We are refactoring how CLI login works. For that, we are introducing
h2 loginandh2 logout, as well as removing--shopflags from certain commands.WHAT is this pull request doing?
h2 loginandh2 logoutcommands.--shopflag from other commands.getCliCommandwhere possible.HOW to test your changes?
Play with different permutations of the related commands:
When not logged in, they should prompt to login. When not linked, they should ask to run
h2 link(env list/pull).💡 I think it would be better to check the code commit by commit.
❓ Should we mark this as a major bump for the CLI package? It's deprecating flags we just introduced in the last release.
Checklist