Skip to content

Commit

Permalink
Remove deprecated --worker CLI flag (#2603)
Browse files Browse the repository at this point in the history
Co-authored-by: Helen Lin <[email protected]>
  • Loading branch information
rbshop and wizardlyhel authored Oct 24, 2024
1 parent ac12293 commit da42a2e
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 15 deletions.
5 changes: 5 additions & 0 deletions .changeset/gorgeous-paws-move.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/cli-hydrogen': minor
---

Remove deprecated --worker cli flag
12 changes: 1 addition & 11 deletions packages/cli/oclif.manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@
"type": "option"
},
"preview": {
"description": "Deploys to the Preview environment. Overrides --env-branch and Git metadata.",
"description": "Deploys to the Preview environment.",
"name": "preview",
"required": false,
"allowNo": false,
Expand Down Expand Up @@ -669,11 +669,6 @@
"allowNo": false,
"type": "boolean"
},
"worker": {
"hidden": true,
"name": "worker",
"type": "boolean"
},
"legacy-runtime": {
"description": "[Classic Remix Compiler] Runs the app in a Node.js sandbox instead of an Oxygen worker.",
"env": "SHOPIFY_HYDROGEN_FLAG_LEGACY_RUNTIME",
Expand Down Expand Up @@ -1323,11 +1318,6 @@
"multiple": false,
"type": "option"
},
"worker": {
"hidden": true,
"name": "worker",
"type": "boolean"
},
"legacy-runtime": {
"description": "Runs the app in a Node.js sandbox instead of an Oxygen worker.",
"env": "SHOPIFY_HYDROGEN_FLAG_LEGACY_RUNTIME",
Expand Down
3 changes: 1 addition & 2 deletions packages/cli/src/commands/hydrogen/deploy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,7 @@ export default class Deploy extends Command {
},
}),
preview: Flags.boolean({
description:
'Deploys to the Preview environment. Overrides --env-branch and Git metadata.',
description: 'Deploys to the Preview environment.',
required: false,
default: false,
}),
Expand Down
1 change: 0 additions & 1 deletion packages/cli/src/commands/hydrogen/dev.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ export default class Dev extends Command {
}),

// For the classic compiler:
worker: deprecated('--worker', {isBoolean: true}),
...overrideFlag(commonFlags.legacyRuntime, {
'legacy-runtime': {
description:
Expand Down
1 change: 0 additions & 1 deletion packages/cli/src/commands/hydrogen/preview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ export default class Preview extends Command {
static flags = {
...commonFlags.path,
...commonFlags.port,
worker: deprecated('--worker', {isBoolean: true}),
...commonFlags.legacyRuntime,
...commonFlags.env,
...commonFlags.envBranch,
Expand Down

0 comments on commit da42a2e

Please sign in to comment.