Fix concatenating requests #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blittle
commented
Sep 1, 2023
| @@ -299,7 +299,7 @@ export async function renderApiRoute( | |||
| return new Request(getRscUrl(url, newUrl), { | |||
| headers: response.headers, | |||
| }); | |||
| } else { | |||
| } else if (!response.headers.get('hydrogen-concatenate')) { | |||
There was a problem hiding this comment.
The problem is line 310 returns a response, and we don't want to get into this crazy form logic. So if this header is present, just return the response on 317. But because the response is really a Request instance, Hydrogen already has functionality to properly process the new Request without actually making a new network request.
wizardlyhel
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Concatenating requests is broken, which is sometimes important for proxying one route to another. This fixes it in a somewhat hacky, but less likely to break other things, way by simply adding a header. This can be tested by booting up the playground and navigating to
/concatenate, notice the/aboutroute is rendered. There's also an e2e test that validates it.Additional context
Before submitting the PR, please make sure you do the following:
fixes #123)yarn changeset addif this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning