Make <CartProvider> use country code from <ShopifyProvider>
#2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminsehl
approved these changes
Jun 5, 2023
blittle
commented
Jun 5, 2023
| @@ -57,7 +58,7 @@ export function CartProvider({ | |||
| data: cart, | |||
| cartFragment = defaultCartFragment, | |||
| customerAccessToken, | |||
| countryCode = CountryCode.Us, | |||
| countryCode, | |||
There was a problem hiding this comment.
The main thing is we don't default a countryCode in the prop, instead use the shopify provider hook to get the default country code.
juanpprieto
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the
<CartProvider>to by default pull localization from<ShopifyProvider>. You can still override the countryCode by passing a prop directly to<CartProvider>. Resolves Shopify/hydrogen#622Additional context
Before submitting the PR, please make sure you do the following:
fixes #123)yarn changeset addif this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning