Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definition conflicts with previous value #795

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

1fabiopereira
Copy link
Contributor

@1fabiopereira 1fabiopereira commented Mar 21, 2023

Description

Fixes #794

This PR fixes the scrollview variable initialization duplicity error.

Reviewers’ hat-rack 🎩

  • Make sure nothing regressed in how FlashList worked before.
  • Make sure that iOS build is working.

Screenshots or videos (if needed)

Checklist

@1fabiopereira 1fabiopereira force-pushed the fix/definition-conflicts branch from d6e387d to 16186ca Compare March 21, 2023 03:13
Copy link
Contributor

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

CHANGELOG.md Show resolved Hide resolved
Co-authored-by: Marek Fořt <[email protected]>
@fortmarek fortmarek merged commit ca58d43 into Shopify:main Mar 30, 2023
@1fabiopereira 1fabiopereira deleted the fix/definition-conflicts branch March 31, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definition conflicts with previous value
2 participants