-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content padding support #626
Conversation
Thank you. When should we expect this? Can't fully migrate our code to flashlist because most of our components uses horizontal padding making. |
@sebastienlabine It'll take sometime. However, for everything other than masonry you can easily apply padding to your items. There's no need to wait for this. |
@fortmarek Can you take a look at this when you have time? It'll be very helpful for the community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩 'd and everything works as expected. Just a couple of nits but nothing that would block merging this 👏
Description
resolves #621
We've had to ignore horizontal padding on vertical lists and the opposite for horizontal ones due to layout complexities. This PR solves the problem and avoids any performance regression.
Motivation
Doing this now was important because, in regular FlashList, padding can simply be added to items but in masonry, we change the order of items and it's quite complex to add something as simple as content padding. Developers need to render and update items based on their columns.
Reviewers’ hat-rack 🎩
contentContainerStyle
in any of the sample.Checklist