fix(#814): update sticky headers when data changes without changing s… #1267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes (issue #814)
To mitigate that issue we need to bypass
PureComponentWrapper
as before it has been only reacting on sticky header index change.
The easies way to understand that issue is
SectionList
example.Let's imagine our
stickyHeaderIndices
contains 3 sections.It will contain the following values
[0, 5, 10]
When we remove first section it will remove element with index
0
with all associated items till next sticky header.
It will result in the following shift in sticky indexes array:
Based on that
PureComponentWrapper
will not recognise that data changedas it receives only index of current sticky header which will be constantly equal to
0
Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)
Checklist