Improvements for validation settings template #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Related #103
Follows #134
Solution
This PR does two things:
api.data.validation?.metafields
to see if a metafield definition exists. However, this field is a bit misleading such that it evaluates to[]
when the definition does not exist OR definition exists and no value is defined. As a result, we end up creating the metafield definition on each rendermetafieldDefinitions
query to explicitly check for existing metafield definitions, and only create a new definition if there is truly no existing definitionBlockStack
, no longer necessary since we provide the layout directly inFunctionSettings
Checklist