Update validation settings templates to be consistent with the tutorial #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Converting this to a draft as we refactor some of the code examples |
avocadomayo
reviewed
Sep 20, 2024
| return ( | ||
| <FunctionSettings onSave={onSave} onError={onError}> | ||
| <ErrorBanner errors={errors} /> | ||
| <BlockStack gap="large"> |
There was a problem hiding this comment.
Will remove this wrapper BlockStack in a follow-up once we close https://github.com/Shopify/web/issues/124573. Applies to all other flavours
cpeddecord
approved these changes
Sep 24, 2024
| api.data.validation?.metafields?.[0]?.value ?? "{}", | ||
| ); | ||
|
|
||
| if (!api.data.validation?.metafields) { |
There was a problem hiding this comment.
could this be inferred by the const configruation up above?
There was a problem hiding this comment.
No, configuration would never be null
There was a problem hiding this comment.
right, but configuration.whatever would be
There was a problem hiding this comment.
Up to taste, my thinking is this is more generalizable, but you could also switch this to !configuration[firstId]
There was a problem hiding this comment.
I extracted shared data access to a var 😄
This was referenced Sep 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Related #103
Corresponds to https://github.com/Shopify/shopify-dev/issues/43285
Changing to a more detailed extension in all 4 flavors to be in line with the tutorial on shopify.dev.
Solution
Added a full solution making use of metafields and
FunctionSettingsandSectioncomponents.Checklist