This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Enable checkAliases for react/no-unsafe rule #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default this rule raises errors on usage of UNSAFE_componentWillMount, UNSAFE_componentWillReceiveProps and UNSAFE_componentWillUpdate. Enabling checkAliases will also raise an error on usage of their unprefixed versions too (componentWillMount, componentWillReceiveProps, componentWillUpdate).
cartogram
approved these changes
Jun 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default this rule raises errors on usage of
UNSAFE_componentWillMount, UNSAFE_componentWillReceiveProps and
UNSAFE_componentWillUpdate.
Enabling checkAliases will also raise an error on usage of their
unprefixed versions too (componentWillMount, componentWillReceiveProps,
componentWillUpdate).
See https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unsafe.md
(There was a brief period where these unprefixed versions triggerd the no-deprecated rule, but that was reverted as they're not actually deprecated just yet as per jsx-eslint/eslint-plugin-react#2069 and jsx-eslint/eslint-plugin-react#2075)