Ensures ActiveSupport is required #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To me it appears that the rubocop complaints might be from an upstream inheritance'd issue? 🤔 |
When using the toolkit outside of Rails against MiniTest users will receive the following error: ``` deprecation_toolkit/lib/deprecation_toolkit.rb:20:in `add_notify_behavior': uninitialized constant ActiveSupport::Deprecation (NameError) ``` This will raise even when not using `ActiveSupport::Deprecation` (i.e. `warn 'Deprecated: this is my deprecation'`) as all deprecations are then passed through `ActiveSupport::Deprecation` in the gem. This PR requires the ActiveSupport dependency if not already defined to cover off these cases. Signed-off-by: Nick Schwaderer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the toolkit outside of Rails against MiniTest users will
receive the following error:
This will raise even when not using
ActiveSupport::Deprecation(i.e.warn 'Deprecated: this is my deprecation') as all deprecations arethen passed through
ActiveSupport::Deprecationin the gem.This PR requires the ActiveSupport dependency if not already defined to
cover off these cases.
Signed-off-by: Nick Schwaderer [email protected]