-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --strict flag to theme push to enforce theme check before pushing #4900
base: main
Are you sure you want to change the base?
Conversation
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1949 tests passing in 886 suites. Report generated by 🧪jest coverage report action from c94de67 |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7e9db50
to
522a33a
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good!
82df6ef
to
5bdcab1
Compare
7853018
to
433a3f8
Compare
5bdcab1
to
f4e461b
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/git.d.ts@@ -97,6 +97,13 @@ export declare class OutsideGitDirectoryError extends AbortError {
* @param directory - The directory to check.
*/
export declare function ensureInsideGitDirectory(directory?: string): Promise<void>;
+/**
+ * Returns true if the given directory is inside a .git directory tree.
+ *
+ * @param directory - The directory to check.
+ * @returns True if the directory is inside a .git directory tree.
+ */
+export declare function insideGitDirectory(directory?: string): Promise<boolean>;
export declare class GitDirectoryNotCleanError extends AbortError {
}
/**
|
Add JSON flag test
Changeset
f4e461b
to
c94de67
Compare
WHY are these changes introduced?
Adds a new
--strict
flag to the theme push command that enforces theme check validation before allowing files to be pushed to a remote theme.WHAT is this pull request doing?
Adds a new
--strict
flag to thetheme push
command that:How to test your changes?
theme push --strict
theme push --strict
againErrors
Warnings
Measuring impact
Checklist