Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readonly mode #428

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Add readonly mode #428

merged 1 commit into from
Nov 24, 2022

Conversation

casperisfine
Copy link
Contributor

Fix: #423

When you know that the cache won't be used again, it avoid some useless work and IOs.

Typically this might be the case for dockerized applications. You generate a cache when building the image, but then when you boot the application any cache update won't be persisted, so thre is no point.

@casperisfine casperisfine requested a review from ChrisBr November 24, 2022 15:23
Fix: #423

When you know that the cache won't be used again, it avoid
some useless work and IOs.

Typically this might be the case for dockerized applications. You
generate a cache when building the image, but then when you boot the
application any cache update won't be persisted, so thre is no point.
Copy link

@ChrisBr ChrisBr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 🙇 ❤️

@casperisfine casperisfine merged commit 95e8d17 into main Nov 24, 2022
@ChrisBr
Copy link

ChrisBr commented Nov 24, 2022

Thanks again Jean, are you planning to cut a new release?

@casperisfine
Copy link
Contributor Author

I can cut a release easily yeah, but would be good if you double checked the use case you had works as expected. You can point the gemfile at the repo.

@shopify-shipit shopify-shipit bot temporarily deployed to rubygems November 25, 2022 04:53 Inactive
technicalpickles added a commit to technicalpickles/rails that referenced this pull request Nov 15, 2023
This was added in back in bootsnap 1.15.0 (Shopify/bootsnap#428).
This can save extra work and IO when the cache won't be changed, like is the case for docker containers
technicalpickles added a commit to technicalpickles/rails that referenced this pull request Nov 16, 2023
This was added in back in bootsnap 1.15.0 (Shopify/bootsnap#428).
This can save extra work and IO when the cache won't be changed, like is the case for docker containers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement read only mode
3 participants