[Flaky test] terminate background thread #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmansoob
force-pushed
the
flaky-test-reset-queue
branch
from
6bb2e4d to
74afcb3
Compare
dalehamel
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a tricky one.
If
AppProfiler::Storage::GoogleCloudStorageTest#test_process_queue_thread_is_alive_after_first_uploadis the first test which runs inAppProfiler::Storage::GoogleCloudStorageTestandAppProfiler::MiddlewareTest#test_profiles_are_not_uploaded_synchronously_when_async_is_requestedran previously,then this will fail:
app_profiler/test/app_profiler/storage/google_cloud_storage_test.rb
Line 81 in b12fc95
Queue and the thread gets reset in
GoogleCloudStorageTest#teardown, but I forgot to do inMiddlewareTest.