Local firefox viewer #144
Merged
Local firefox viewer #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
force-pushed
the
firefox_local_viewer
branch
2 times, most recently
from
7277c5f to
a52fc5e
Compare
dalehamel
approved these changes
Nov 21, 2024
| private_constant(:PACKAGE) | ||
| VALID_COMMANDS = [ | ||
| *VALID_COMMANDS, | ||
| ["git", "clone", "https://github.com/tenderlove/profiler", "firefox-profiler", "--branch=v0.0.2"], |
There was a problem hiding this comment.
for a future PR, i wonder if we could just use the gem and extract the sources from that. This branch is out of date and doesn't have the latest changes already.
There was a problem hiding this comment.
Good point. I'll try to account for this in another PR.
There was a problem hiding this comment.
We make changes to the source so I don't think extracting from the gem is the best idea, unless we plan to copy it somewhere.
There was a problem hiding this comment.
The changes are basically just so we can compile it as a package IIRC. We might be able to get away with just extracting the sources from the gem as-is?
Adds local firefox viewer and mkes it the default for vernier viewing.
gmcgibbon
force-pushed
the
firefox_local_viewer
branch
from
a52fc5e to
96ea13e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds local firefox viewer and makes it the default for vernier viewing.
This change requires changes in profile-viewer: tenderlove/profiler#4