Switch height
to a function and not a variable
#212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow for header and footer width to be passed to the functional table data.
More specifically,
FunctionalTableData.Delegate
'sUITableViewDelegate
implemenation nowuses
tableView
's width intableView(_:heightForHeaderInSection:)
andtableView(_:heightForFooterInSection)
.We achieved this functionality while maintaining backwards compatibility by adding a
protocol method to both
TableHeaderFooterConfigType
andTableHeaderFooterStateType
calledfunc height(given width: CGFloat) -> CGFloat?
. If this method returnsnil
, thenthe table view delegate methods will use the current
height
property already defined, otherwiseit will use the provided by the new methods.
Each protocol provides a public default implemenation so that library consumers
need not implement this method unnecessarily.