Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for mypy 0.750 #13

Merged
merged 3 commits into from
Nov 30, 2019
Merged

Conversation

arnimarj
Copy link
Contributor

Hi,

I was testing out the upcoming mypy release on our codebase, and fixed the issues I encountered. The were all about some nodes don't have a fullname()/name() -> str method, and instead the values are now exposed via a string attribute.

We ran this across the repos we have with decent annotation coverage, and had no further issues.

According to python/mypy#7947 we can expect a new mypy release in 2 days.

@kedder
Copy link
Member

kedder commented Nov 26, 2019

Cool, thanks a lot! Let's wait for the release and rerun the travis build

@arnimarj
Copy link
Contributor Author

Mypy 0.750 just got released. The Travis run in my repo just passed so I expect it will pass here once restarted.

@arnimarj
Copy link
Contributor Author

A few things seem to have changed before the final release, and the branch has been updated accordingly.

@kedder
Copy link
Member

kedder commented Nov 30, 2019

Thank you, merging!

@kedder kedder merged commit 007e0aa into Shoobx:master Nov 30, 2019
@kedder
Copy link
Member

kedder commented Nov 30, 2019

mypy-zope-0.2.3 is pushed to pypi: https://pypi.org/project/mypy-zope/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants