-
Notifications
You must be signed in to change notification settings - Fork 76
Commit
Added 1.0 header for /Stream/ endpoint; Bypassed the ASPNetCore ? error ?; Endpoint working correct;
- Loading branch information
There are no files selected for viewing
7 comments
on commit 06490f4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No seeking is not okay. I'll write my own if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did for Nancy, after all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HttpContext should also never be null in a HTTP request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a bug in ASPNetCore that would make HttpContext null;
But simple update of components didn't helped enough.
Can't tell if this is the same issue or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotnet/aspnetcore#7975
But probably its not about this... don't know not into aspnetcore that much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bigretromike That wouldn't relate to the issue, since we are using .net 4.7 and that explicitly state's .net core 2.2.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought so, also when I updated all ASPNET related libraries (there's like 61 to update for Shoko Project) for testing it didn't solved the issue, so I didn't pushed it because knowing it there would be more harm than profit.
This issue was more than I could chew, so I fallback it so it would stream files, with our without ranges.
@da3dsoul as HttpContext.Request is Null because of the ASPCore (bug, I read about that being null but it was supposed to be fix in 2.2 but I updated and it didn't helped and I didn't want to updated because something else could break) the byterange in not supported, so you cannot fast-seek file anymore.
It didn't work before, to fallback to working is ok, but without seek watching is not the same...