Fix capitalization in C include statements #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, the include statements lead to file-not-found errors because the operating system considers the capitalization of the include statements.
marknolan
reviewed
Sep 21, 2021
| @@ -1,6 +1,6 @@ | |||
| #include "msp430.h" | |||
| #include "RN42.h" | |||
| #include "../5XX_hal/hal_DMA.h" | |||
| #include "../5XX_HAL/hal_DMA.h" | |||
marknolan
reviewed
Sep 21, 2021
| @@ -43,7 +43,7 @@ | |||
| #include "ads1292.h" | |||
| #include "msp430.h" | |||
| #include <string.h> | |||
| #include "../5XX_hal/hal_UCA0.h" | |||
| #include "../5XX_HAL/hal_UCA0.h" | |||
marknolan
reviewed
Sep 21, 2021
| @@ -43,7 +43,7 @@ | |||
| #include "ads1292.h" | |||
| #include "msp430.h" | |||
| #include <string.h> | |||
| #include "../5XX_hal/hal_UCA0.h" | |||
| #include "../5XX_HAL/hal_UCA0.h" | |||
marknolan
reviewed
Sep 21, 2021
| @@ -1,6 +1,6 @@ | |||
| #include "msp430.h" | |||
| #include "RN42.h" | |||
| #include "../5XX_hal/hal_DMA.h" | |||
| #include "../5XX_HAL/hal_DMA.h" | |||
|
We'll be updating the master branch with the fixes discussed in this pull request and these will be included in the next firmware release. |
|
The new version seems to have the same problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I work with the Shimmer firmware on Linux where the filesystem is case sensitive. This leads to several errors when building the project because some include statements are not correctly capitalized. The following pull request fixes all include statements that would otherwise prevent the build.