fix ConcurrentModificationException #425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the use of
clearableRefs
in the methodclearAllReferences
method is incorrect.The type of
clearableRefs
is synchronizedList. Although the safeList is thread-safe, its iterator is not.According to Javadocs :
I think this is the root cause of the occurrence of ConcurrentModificationException.
To analyze more specifically, why is there a very small chance of a ConcurrentModificationException occurring
When the use of heap memory exceeds the limit,
notificationListener.notifyHeapAboveThreshold()
will be called. It runs the clearing of references asynchronously there, which involves modifying clearableRefs.Is it possible that when the
clearAllReferences()
method is called, some of the threads initiated by thenotificationListener.notifyHeapAboveThreshold()
method have not finished executing. This leads to the use ofclearableRefs.spliterator()
to generate the iterator ofclearableRefs
for traversal, andclearableRefs
is modified by other threads again.Resolves #424