Add support for deleting music from play queue #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For Sherlockouo#111 Signed-off-by: EndCredits <[email protected]>
Signed-off-by: EndCredits <[email protected]>
Signed-off-by: EndCredits <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings, devs.
This pull request attempting to implement a feature requested by #111
When it comes to why we need commit ee75308. I think It's an inelegant approach directly hacking trackList to modify trackID. So I choose to check whether we are attempting to delete the song we are currently playing. If so we switch to previous song first then delete the song that user wants to delete. After that switch to the next song and continue our play.
Test: Build and basic function check, try to delete song from the playing queue and it works
CI build can be found here: 22