Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added utility methods + naming scheme changes #47

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Daniel1464
Copy link
Contributor

  1. Changed "getGamePiecesByType" to "getGamePiecePoses" which makes it a bit more descriptive
  2. Added "getNotePoses" method to make mispelling the gamepiece type less common for notes(in 2025, we can add the respective methods for the new gamepieces)
  3. Renamed "GamePieceOnFieldSimulation" to "GamePieceOnField" to make it more consistent with "GamePieceProjectile"
  4. Change the return types of getGamePiecePoses/getNotePoses to arrays instead of lists to allow for easier logging(most logging frameworks unfortunately don't support list logging)
  5. Updated the docs as well(currently, the docs demonstrate logging a List via Logger.recordOutput which doesn't work).

@Daniel1464
Copy link
Contributor Author

Note: I'm not sure if there's anything I have to do in order to update the javadocs(they seem to be autogenerated, but idk how to refresh them)

@Daniel1464
Copy link
Contributor Author

Also, after realizing that fps' changes haven't been merged yet, this should probably hold off to another time(unless if beta 2 comes out with his changes)

@catr1xLiu catr1xLiu changed the base branch from main to dev November 22, 2024 00:33
@catr1xLiu
Copy link
Contributor

LGTM, and thanks for the help!

But you're right, I should probably merge this after merging the new APIs by @oh-yes-0-fps, otherwise there'll be a ton of conflicts.

@catr1xLiu catr1xLiu added the enhancement New feature or request label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants