Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target NET 7.0 #180

Closed
wants to merge 1 commit into from
Closed

Target NET 7.0 #180

wants to merge 1 commit into from

Conversation

erdihu
Copy link

@erdihu erdihu commented Mar 2, 2023

This PR tries to resolve #179
I don't have much experience about nuget packages but if any other changes are needed I can try to do those as well.

@Shazwazza
Copy link
Owner

Looks pretty good! Prob don't need to install both .NET 7 and 6 in the GH actions (I could be wrong though). I'll test soon. Thanks!

@PhyxionNL
Copy link
Contributor

Looks pretty good! Prob don't need to install both .NET 7 and 6 in the GH actions (I could be wrong though). I'll test soon. Thanks!

It would be necessary, but instead of adding this task three times, it could just be one like this:

  with:
    dotnet-version: | 
      5.0.x
      6.0.x
      7.0.x

But we really should drop 3..x and 5.x in Smidge given that they're long out of support.

@Shazwazza
Copy link
Owner

@PhyxionNL Any chance you might have time to clone this fork and make that update to this PR?

@PhyxionNL
Copy link
Contributor

With or without old .NETs?

@PhyxionNL PhyxionNL mentioned this pull request May 19, 2023
@PhyxionNL
Copy link
Contributor

#192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider targeting for .NET 7
4 participants