Merge pull request #214 from willdean/develop

Avoid CssMinifier stripping spaces that are followed by colons
Shazwazza · Nov 6, 2024 · 3436b51 · 3436b51
2 parents 3ad9bfe + a11e46e
commit 3436b51
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/src/Smidge.Core/FileProcessors/CssMinifier.cs b/src/Smidge.Core/FileProcessors/CssMinifier.cs
@@ -80,7 +80,6 @@ private void ExecuteCssMin()
                                 {
                                     case ' ':        //body.Replace("  ", String.Empty);
                                     case '{':        //body = body.Replace(" {", "{");
-                                    case ':':        //body = body.Replace(" {", "{");
                                     case '\n':       //body = body.Replace(" \n", "\n");
                                     case '\r':       //body = body.Replace(" \r", "\r");
                                     case '\t':       //body = body.Replace(" \t", "\t");
@@ -300,4 +299,4 @@ private void Put(int c)
     //        return Task.FromResult(input);
     //    }
     //}
-}
+}
diff --git a/test/Smidge.Tests/CssMinTests.cs b/test/Smidge.Tests/CssMinTests.cs
@@ -135,5 +135,23 @@ public async Task Strip_Comments()
 
         }
 
+        [Fact]
+        public async Task CssMin_Ensure_Spaces_Not_Stripped_From_Complex_Selectors()
+        {
+            //refer to this: https://github.com/Shazwazza/Smidge/issues/139
+            //The problem is stripping spaces which are followed by a colon - that's not OK this type of selector
+
+            var css = ".prose :where([class~=lead]):not(:where([class~=not-prose] *)){}";
+
+            var minifier = new CssMinifier();
+            using (var bc = BundleContext.CreateEmpty("1"))
+            {
+                var fileProcessContext = new FileProcessContext(css, Mock.Of<IWebFile>(), bc);
+                await minifier.ProcessAsync(fileProcessContext, ctx => Task.FromResult(0));
+
+                Assert.Equal(css, fileProcessContext.FileContent);
+            }
+        }
+
     }
-}
+}