Fix Culture Varying Blog Page not returning BlogLogo in GetArticulateCropUrl #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s blogBanner image Looks like the GetArticulateCropUrl is called in two places in the MasterModel.cs, once for "blogLogo" and then another time for "blogBanner" - if the page doesn't vary by culture, all is ok the GetCropUrl is called with the appropriate propertyalias passed in.... but in the circumstance that the page does vary by culture it's hardcoded to only use the "blogBanner"... this tweak means the propertyalias passed will be used...
|
So sorry for the delay here! I'll get to this this afternoon |
|
Thanks @marcemarc ! |
no problem! good to hear from you, hope all going well post Umbraco HQ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Blog page varies by culture... GetArticulateCropUrl only returns blogBanner image property.
Looks like the GetArticulateCropUrl is called in two places in the MasterModel.cs, once for "blogLogo" and then another time for "blogBanner"
if the page doesn't vary by culture, all is ok the GetCropUrl is called with the appropriate propertyalias variable passed in....
... but in the circumstance that the page does vary by culture it seems hardcoded to only use the "blogBanner"...
this tweak means the propertyalias variable passed in will be used, and it will return the appropriate image...