V9: Fix Markdown mobile editor #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 8, 2022 10:22
…play comments turned on Enable comments is true by default when using the markdown editor
…onse as opposed to raw string that was using quotes in the response for the URL
…100% sure this is needed
Shazwazza
requested changes
Jul 18, 2022
There was a problem hiding this comment.
Great work! I added a couple comments in there. Your PR message says:
Please thoroughly test the upload logic, and it works as expected still
Do you mean you thoroughly tested it, or you want me to thoroughly test it? I trust your testing and prob wont have time this week :)
src/Articulate/App_Plugins/Articulate/Views/MarkdownEditor.cshtml
Outdated
Show resolved
Hide resolved
added 3 commits
July 20, 2022 10:05
|
Updated with your suggestions and I have done testing, but was asking for you to test it as well, but if you trust me then all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes up the API Controller used in the mini AngularJS app for mobile posting with the url
/a-newPlease thoroughly test the upload logic, and it works as expected still