Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSearch Route #393

Merged
merged 5 commits into from
Jul 5, 2022
Merged

OpenSearch Route #393

merged 5 commits into from
Jul 5, 2022

Conversation

warrenbuckley
Copy link
Contributor

@warrenbuckley warrenbuckley commented Jul 4, 2022

Fixes up the OpenSearch Route that is in the list of things needed to be done for Umbraco V9 support #381

Note
Problem was mostly that the controller was a plain ole controller and not a RenderController that the Router was expecting
https://github.com/Shazwazza/Articulate/blob/release/5.0.0/src/Articulate/Routing/ArticulateRouter.cs#L130

Also I can browse to it, but I am not sure how I am supposed to test the OpenSearch stuff in my browser apart from navigating to it directly. I thought it would appear as a search option or something ?!

@warrenbuckley
Copy link
Contributor Author

@Shazwazza The CI build seems to be failing for Nuget package restore - Is the AppVeyor CI build still alive or has it been moved or... ?!

@Shazwazza
Copy link
Owner

Open search is a browser thing. This works for me in Edge but no longer in Chrome (though it should) and it should also work in Firefox too.

Do this - for example - type in https://shazwazza.com/ in the browser bar and then press Tab instead of enter and you should get something like:

image

and then you can type anything to search on like:

image

then press Enter and you'll be redirected to:

image

Here's some docs on opensearch in browsers

https://developer.mozilla.org/en-US/docs/Web/OpenSearch
https://www.chromium.org/tab-to-search/

My tests in Chrome now fail though, so not sure if Chrome removed this feature or something else is wrong. I found this https://stackoverflow.com/questions/8650377/opensearch-description-document-discovery-and-chrome but not sure if that helps. I also tried tab searching in YouTube.com on chrome and it doesn't work so I have a feeling they killed support for it?

@warrenbuckley
Copy link
Contributor Author

Ok thanks will try that but yeh the route returns some XML

@Shazwazza
Copy link
Owner

Cool, well I think that's what we want :) if it doesn't work in some browsers, it's possibly another bug or browser issue

@Shazwazza Shazwazza merged commit f85ad7f into Shazwazza:release/5.0.0 Jul 5, 2022
@warrenbuckley warrenbuckley deleted the routing/opensearch branch July 6, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants