Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #385. #386

Conversation

FloppyChips
Copy link

Resolves #385.

@FloppyChips
Copy link
Author

Please can we progress this one, we'd like to include this project in our release. Great job by the way! Regards Stuart

@Shazwazza
Copy link
Owner

Hi thanks for this. It's been a long time since I looked at that code but IIRC there was a reason why 'localhost' needed to be checked there. Any chance you can provide me with some additional context as to these changes while you were debugging? I just don't want to release a breaking change.

@FloppyChips
Copy link
Author

FloppyChips commented May 25, 2022

True this doesn't seem to have changed since first written. We noticed a problem when we added a second domain under the Culture and Hostnames settings in Umbraco, so we now have 1) https://localhost:44300 and 2) https://some_real_domain. I can't say this won't break anything but I think its clear there is some inconsistency between the hosts that are going into the list _urlNames and how they are being matched at the moment. It might be that checking for "localhost" at both points would also be a fix. Note that we wanted to have multiple blogs eventually but at the moment we just moved the Blog from under the root to under a sub-node.

@FloppyChips
Copy link
Author

I can confirm that

private const string DetectDomainAbsoluteUrl = "localhost";

also works for us if you would rather have that.

@FloppyChips
Copy link
Author

I have proposed an update where "localhost" is used in the comparison as discussed above, this also works for us.

@Shazwazza Shazwazza merged commit 56f79a2 into Shazwazza:develop Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 On Tags / Category Page after moving content node from root to multisite node
2 participants