Fix potential jetcd core shading problem #3
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a potential jar shading issue introduced in apache#4426 that causes
NoClassDefFoundError
when connecting to an etcd metadata store.The
jetcd-core-shaded
module was introduced in apache#4426 to address the compatibility issues between jetcd-core’s grpc-java dependency and Netty. You can find more details here and in the grpc-java documentation.Currently, we use
unpack-shaded-jar
execution unpacks the shaded jar produced bymaven-shade-plugin:shade
into thejetcd-core-shaded/target/classes
directory. However, the classes in this directory conflict with its dependencies. If themaven-shade-plugin:shade
runs again without cleaning this directory, it can produce an incorrect shaded jar. You can replicate and verify this issue with the following commands:We can remove the attach and unpack configurations, and it should work fine.
This issue has already been reported in apache/pulsar, and a similar patch has addressed it.