Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/ordered autoload #126

Merged
merged 5 commits into from
Jun 4, 2024
Merged

F/ordered autoload #126

merged 5 commits into from
Jun 4, 2024

Conversation

nuchs
Copy link
Contributor

@nuchs nuchs commented Jun 4, 2024

Hi there, this is a pull request for the issue I raised. This should allow users to specify mutliple auotload options and on startup each will be tried in order until one succeds.

I had considered adding a new startup option that looked to see if the current directory had a session associated with it and if not use the last session but I saw someone else had submitted a pull request for git sessions and I thought a list of options would be more compatible with that.

I've not really done any work with lua before so apologies if it is a little un-idiomatic, I'm happy to tidy it up however you like

I've alos tried to make it so the change won't break any existing configurations

lua/session_manager/init.lua Show resolved Hide resolved
Copy link
Owner

@Shatur Shatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Left a few more suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lua/session_manager/init.lua Show resolved Hide resolved
@nuchs
Copy link
Contributor Author

nuchs commented Jun 4, 2024

I've updated the formatting and docs as asked, the only thing I was a little unsure about was what you meant by the function docs. Did you mean the comments above the functions, the notes in the readme (both of which I think I've done) or something else?

Copy link
Owner

@Shatur Shatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what I meant, thank you!

@Shatur Shatur linked an issue Jun 4, 2024 that may be closed by this pull request
@Shatur Shatur merged commit b3058f6 into Shatur:master Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple startup options to be tried in order
2 participants