Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIUI support and improve error handling for DumpScreen and DumpScreenString #68

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

yungd1plomat
Copy link
Member

  • When using DumpScreenString with MIUI OS Andoid 11+ it's throw error before xml:

    java.io.FileNotFoundException: /data/system/theme_config/theme_compatibility.xml: open failed: ENOENT (No such file or directory)
    ...
    <?xml version='1.0' encoding='UTF-8' standalone='yes' ?><hierarchy>...</hierarchy>UI hierchary dumped to: /dev/tty
    

    Solution: Filter out the exception from response (from XML parsing error when using MIUI 12 on Pocophone X3 #283 )

  • If XML contains an error, null is returned

    Solution: Throw an exception if the response does not contain valid xml

@yungd1plomat yungd1plomat added the bug Something isn't working label Aug 14, 2023
@wherewhere
Copy link
Member

GitHub crushed🤣

DumpScreenString return empty string instead of null
@wherewhere
Copy link
Member

wherewhere commented Aug 15, 2023

I will merge it if there is nothing to add. 幽灵幽灵幽灵

@wherewhere wherewhere linked an issue Aug 16, 2023 that may be closed by this pull request
@wherewhere wherewhere merged commit 7c617b7 into main Aug 16, 2023
@wherewhere wherewhere deleted the miuifix branch August 16, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShellCommandUnresponsiveException while DumpScreenAsync
2 participants