Enabled testing of APCU for all PHP versions when running with all extensions enabled

[boenrobot]

Enabled testing of APCU for all PHP versions when running with all extensions enabled;

Removed a few instances of erroneous doesNotPerformAssertions annotations.

---

With APC(u) enabled, there are two test failures:

1) Zend_Cache_TwoLevelsBackendTest::testSaveOverwritesIfFastIsFull
Failed asserting that false is true.

/home/runner/work/zf1-future/zf1-future/tests/Zend/Cache/TwoLevelsBackendTest.php:124
/home/runner/work/zf1-future/zf1-future/tests/resources/Runner.php:20
/home/runner/work/zf1-future/zf1-future/tests/Zend/AllTests.php:143
/home/runner/work/zf1-future/zf1-future/tests/Zend/AllTests.php:[267](https://github.com/boenrobot/zf1-future/actions/runs/5821371801/job/15783687811#step:14:268)
phpvfscomposer:///home/runner/work/zf1-future/zf1-future/vendor/phpunit/phpunit/phpunit:60

2) Zend_Cache_TwoLevelsBackendTest::testSaveReturnsTrueIfFastIsFullOnFirstSave
Failed asserting that null matches expected 90.

/home/runner/work/zf1-future/zf1-future/tests/Zend/Cache/TwoLevelsBackendTest.php:152
/home/runner/work/zf1-future/zf1-future/tests/resources/Runner.php:20
/home/runner/work/zf1-future/zf1-future/tests/Zend/AllTests.php:143
/home/runner/work/zf1-future/zf1-future/tests/Zend/AllTests.php:267
phpvfscomposer:///home/runner/work/zf1-future/zf1-future/vendor/phpunit/phpunit/phpunit:60

And honestly, I'm not entirely sure what's going on there, as I've never used two level cache. I wonder if I should mark those tests incomplete and we move on? Is this a legit bug that needs fixing? And if it's a legit bug, I'm not sure how to fix it.

[develart-projects]

Actually merging that with 2 failing tests is not the best practice :)
Anyone to take a look in that?

[boenrobot]

Some more trial & error seems to give a bit of a hint with the test failures, though I'm still not sure how to fix the code or test (whichever one is actually broken...).

In PHP 8.1 and later, the unserialize() inside the two level cache's load returns false in the testSaveReturnsTrueIfFastIsFullOnFirstSave test, which in turn causes errors about array access on bool (rendering the test "errored"). I added a check for that which, if it fails, will do a remove of the key in both caches and return false in that case. When I do that, the outcome of the test in PHP 8.1 is now like in PHP 7.1 (which is what the results of the above were from).

Further adjusting the behavior of load() to remove only the fast cache on corruption and try the slow in that case (succeeding and potentially repopulating the fast cache if the slow succeeds) fixes the testSaveReturnsTrueIfFastIsFullOnFirstSave test in all PHP versions.

testSaveOverwritesIfFastIsFull remains failing, even with that change in behavior, and I'm still not sure how unserialize() ends up returning NULL in the first place. That should in theory only happen if the data originally serialized was NULL, but all calls to save() seem to save an array.

[develart-projects]

Moving to 1.23.2, as we have some PRs to be released ASAP.

[boenrobot]

OK, it seems the problem was in the test... The test uses a full mock, without specifying what to do on save and load, leading to the fast backend in the test returning NULL all the time, which in turn means it failed. Using partial mock that explicitly mocks only getFillingPercentage() fixes this.

Should I keep the debug messages in the code I wonder, since they were instrumental in detecting the problem? There is probably a negligible overhead in checking if a debug logger is configured...

[develart-projects]

@boenrobot question is, if this is somehow interfering with anything. I mean the debug messages. If not, we probably should keep them.

[boenrobot]

@boenrobot question is, if this is somehow interfering with anything. I mean the debug messages. If not, we probably should keep them.

No. No interference, i.e. no change in behavior.

The only costs are

1. The neglegible bit of performance penalty of checking if there is a logger, and in the event that there is, the writing of a few debug messages.
2. Possibly more logging noise if you turn on debug logs or (in the case of the file cache) warning logs.