Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] bumped bull, redis to latest, fixes a specified db from the config #27

Merged
merged 1 commit into from
Apr 8, 2016

Conversation

rook2pawn
Copy link
Contributor

@ShaneK Bull was updated 4/8/16 to fix a longstanding issue which now allows the user to correctly select the db number for each queue in redis CreateClient; so as far as Matador is concerned updating both the bull and redis package are required to allow the user to select the db from within the config and will easily make Matador feature compatible with the new Bull.

e.g..

{
"port": 1337,
"redis": {
    "host": "localhost",
    "port": 6379,
    "options" : {
      "db" : 2
    }
},
"errorPages": {
    "404": "errors/404",
    "not-connected": "errors/not-connected"
},
"development": true
}

@rook2pawn rook2pawn force-pushed the fix-selected-db branch 2 times, most recently from c757f5a to 95015ac Compare April 8, 2016 17:58
@ShaneK ShaneK merged commit dbec8bd into ShaneK:master Apr 8, 2016
@ShaneK
Copy link
Owner

ShaneK commented Apr 8, 2016

Thank you for letting me know and for the PR. I'll update Matador on npm shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants