Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional built building count to recipe rows #118

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on May 23, 2021

  1. Add builtBuildings variable to RecipeRow

    This variable, which defaults to null, can be used to track the number of buildings that have actually been built. This number has no impact on the model.
    Saklad5 committed May 23, 2021
    Configuration menu
    Copy the full SHA
    a5ad558 View commit details
    Browse the repository at this point in the history
  2. Add dropdown menu items for changing builtBuildings

    Dropdown menu items for setting or clearing the builtBuildings value have been added for each recipe row.
    
    These items mirror the behavior and implementation of those for fixedBuildings, for the most part.
    The initial value is buildingCount rounded up, or 0 if buildingCount is negative.
    As 0 is a valid value, clearing builtBuildings returns it to null.
    
    Shopping lists now use the builtBuildings value instead of buildingCount if the former is not null.
    Saklad5 committed May 23, 2021
    Configuration menu
    Copy the full SHA
    7478a67 View commit details
    Browse the repository at this point in the history
  3. Add text field for builtBuildings

    The text field is only visible if builtBuildings is not null, and is placed under the building count. It is colored grey to indicate that it is not playing a role in the model.
    Saklad5 committed May 23, 2021
    Configuration menu
    Copy the full SHA
    ef43865 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Treat buildingCount above builtBuildings as error

    If the number of buildings needed for the model's solution is greater than the specified number of built buildings, the recipe will now be flagged accordingly.
    This makes it substantially easier to determine which recipes need to be revisited if a change is made.
    Saklad5 committed May 24, 2021
    Configuration menu
    Copy the full SHA
    d66426f View commit details
    Browse the repository at this point in the history
  2. Add page-wide error for builtCountExceeded

    To make issues more apparent, the entire page now displays an error message (like with deadlocks) if a recipe needs more machines than it currenty has built.
    Saklad5 committed May 24, 2021
    Configuration menu
    Copy the full SHA
    b8c720d View commit details
    Browse the repository at this point in the history