Implement LED source output device

.vscode/launch.json

@@ -0,0 +1,79 @@
+{
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "name": "Remote launch",
+            "type": "lldb",
+            "request": "launch",
+            "program": "${workspaceFolder}/target/debug/inputplumber",
+            "sourceLanguages": ["rust"],
+            "initCommands": [
+                "platform select remote-linux",
+                "platform connect connect://192.168.1.19:1234",
+                "settings set target.inherit-env false"
+            ],
+            "env": {
+                "PATH": "/usr/bin:/usr/local/sbin:/usr/local/bin:/var/lib/flatpak/exports/bin:/usr/lib/rustup/bin"
+            }
+        },
+        {
+            "type": "lldb",
+            "request": "launch",
+            "name": "Debug unit tests in library 'inputplumber'",
+            "cargo": {
+                "args": [
+                    "test",
+                    "--no-run",
+                    "--lib",
+                    "--package=inputplumber"
+                ],
+                "filter": {
+                    "name": "inputplumber",
+                    "kind": "lib"
+                }
+            },
+            "args": [],
+            "cwd": "${workspaceFolder}"
+        },
+        {
+            "type": "lldb",
+            "request": "launch",
+            "name": "Debug executable 'inputplumber'",
+            "cargo": {
+                "args": [
+                    "build",
+                    "--bin=inputplumber",
+                    "--package=inputplumber"
+                ],
+                "filter": {
+                    "name": "inputplumber",
+                    "kind": "bin"
+                }
+            },
+            "args": [],
+            "cwd": "${workspaceFolder}"
+        },
+        {
+            "type": "lldb",
+            "request": "launch",
+            "name": "Debug unit tests in executable 'inputplumber'",
+            "cargo": {
+                "args": [
+                    "test",
+                    "--no-run",
+                    "--bin=inputplumber",
+                    "--package=inputplumber"
+                ],
+                "filter": {
+                    "name": "inputplumber",
+                    "kind": "bin"
+                }
+            },
+            "args": [],
+            "cwd": "${workspaceFolder}"
+        }
+    ]
+}

src/dbus/interface/source/evdev.rs

@@ -19,9 +19,11 @@ pub struct SourceEventDeviceInterface {
 
 impl SourceEventDeviceInterface {
     pub fn new(device: UdevDevice) -> SourceEventDeviceInterface {
-        let handler = device.devnode();
-        let capabilities = get_capabilities(handler.as_str()).unwrap_or_else(|e| {
-            log::warn!("Failed to get capabilities for source evdev device '{handler}': {e:?}");
+        let capabilities = get_capabilities(device.devnode().as_str()).unwrap_or_else(|e| {
+            log::warn!(
+                "Failed to get capabilities for source evdev device '{}': {e:?}",
+                device.name()
+            );
             HashMap::new()
         });
         SourceEventDeviceInterface {

src/drivers/opineo/driver.rs

@@ -1,6 +1,7 @@
 use std::{
     error::Error,
     ffi::CString,
+    path::Path,
     time::{Duration, Instant},
 };
 
@@ -51,12 +52,24 @@ pub struct Driver {
 impl Driver {
     pub fn new(udevice: UdevDevice) -> Result<Self, Box<dyn Error + Send + Sync>> {
         let path = udevice.devnode();
-        let cs_path = CString::new(path.clone())?;
+        if !Path::new(path.as_str()).exists() {
+            return Err(format!(
+                "Device '{}' does not have a devnode: a valid OrangePi NEO Controller has one",
+                udevice.name()
+            )
+            .into());
+        }
+
+        let cs_path = CString::new(path)?;
         let api = hidapi::HidApi::new()?;
         let device = api.open_path(&cs_path)?;
         let info = device.get_device_info()?;
         if info.vendor_id() != VID || info.product_id() != PID {
-            return Err(format!("Device '{path}' is not a OrangePi NEO Controller").into());
+            return Err(format!(
+                "Device '{}' is not a OrangePi NEO Controller",
+                udevice.name()
+            )
+            .into());
         }
 
         Ok(Self {

src/drivers/rog_ally/driver.rs

@@ -1,4 +1,4 @@
-use std::{error::Error, ffi::OsStr, time::Duration};
+use std::{error::Error, ffi::OsStr, path::Path, time::Duration};
 
 use udev::Device;
 
@@ -19,8 +19,17 @@ impl Driver {
         let vid = udevice.id_vendor();
         let pid = udevice.id_product();
         if VID != vid || !PIDS.contains(&pid) {
-            return Err(format!("'{}' is not an ROG Ally controller", udevice.devnode()).into());
+            return Err(format!("Device {} is not a ROG Ally controller", udevice.name()).into());
         }
+
+        if !Path::new(udevice.devnode().as_str()).exists() {
+            return Err(format!(
+                "Device {}, part of a ROG Ally controller does not have a devnode",
+                udevice.name()
+            )
+            .into());
+        }
+
         // TODO: When resuming from sleep, if mcu_powersave is set, the device init takes longer.
         // inotify will trigger this driver before the attribute tree is fully built and the driver
         // will error and exit, leaving some controls unusable. We should find a way to only

src/drivers/xpad_uhid/driver.rs

@@ -1,4 +1,4 @@
-use std::{error::Error, ffi::CString};
+use std::{error::Error, ffi::CString, path::Path};
 
 use hidapi::HidDevice;
 use packed_struct::PackedStruct;
@@ -47,17 +47,29 @@ pub struct Driver {
 
 impl Driver {
     pub fn new(udevice: UdevDevice) -> Result<Self, Box<dyn Error + Send + Sync>> {
-        let path = udevice.devnode();
         let driver = udevice.drivers();
         if !driver.contains(&"microsoft".to_string()) {
-            return Err(format!("Device '{path}' is not using the hid-microsoft driver").into());
+            return Err(format!(
+                "Device '{}' is not using the hid-microsoft driver",
+                udevice.name()
+            )
+            .into());
         }
+
+        if !Path::new(udevice.devnode().as_str()).exists() {
+            return Err(format!(
+                "Device {} an xpad controller does not have a devnode",
+                udevice.name()
+            )
+            .into());
+        }
+
         let syspath = udevice.syspath();
         if !syspath.contains("uhid") {
-            return Err(format!("Device '{path}' is not a uhid virtual device").into());
+            return Err(format!("Device '{}' is not a uhid virtual device", udevice.name()).into());
         }
 
-        let cs_path = CString::new(path.clone())?;
+        let cs_path = CString::new(udevice.devnode().clone())?;
         let api = hidapi::HidApi::new()?;
         let device = api.open_path(&cs_path)?;