forked from stm32-rs/stm32f3xx-hal
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use verbose keywords in linker fragments #5
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which is the discovery board used for this testsuite
This is needed, so probe-run can get enough information to verify a test sucess even in release mode
Now that this is fixed, examples are building again in the root folder and ci can use cargo -p testsuite again
This reverts commit 18c415b.
Accessing the USARTs TDR is safe again with stm32f3 0.13.2.
As this section gets bigger, I moved it into its own README.md in testsuite/.
Give more prominent information on wiring for test
Clean up unsafe write to USART TDR
Even after unplugging my STM32F3DISCOVERY MB1035D for several hours, I'm getting a noise error in this test case.
…ariants Accept different errors in send_receive_wrong_baud
When using flip-link for stack overflow protection, it parses the linker scripts/fragments for RAM memory addresses and expects the keywords 'ORIGIN' and 'LENGTH' to be used in its verbose form. Allow friction-less integration of flip-link and this crate by using the verbose form.
e123b09
to
95b17fc
Compare
Thanks! This is a good catch. I've just disable flip-link in my case, because it was not building correctly but haven't looked into why that was the case. I've cleanup the more-tests branch, so this patch is difficult to just merge this way. Instead I've just cherry-picked your commit into stm32-rs#212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
flip-link
for stack overflow protection, it parses the linker scripts/fragments for RAM memory addresses and expects the keywordsORIGIN
andLENGTH
to be used in its verbose form. Allow friction-less integration offlip-link
and this crate by using the verbose form.Otherwise using
flip-link
would result in an error like the following: