Implement SpecificationAttribute/ProductSpecificationAttribute #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpose ProductSpecificationAttirbute array on Product API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request exposes new API endpoints that allow for interacting with SpecificationAttributes and ProductSpecificationAttributes. Additionally, it adds an array of ProductSpecificationAttributes to the product API responses.
The new endpoints are as follows:
For the sake of consistency with existing code, the structure is based off of the ProductAttributes API implementation. I did not add documentation. I can add it, if needed, but I think the existing documentation is incomplete anyway (ex: ProductAttributes), so that might be worth tackling as one larger task.