Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for symfony/http-kernel "^6.0" #110

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

JordiDekker
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5ebfe61) 5.13% compared to head (b61c6b7) 5.13%.

❗ Current head b61c6b7 differs from pull request most recent head 37207cf. Consider uploading reports for the commit 37207cf to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             master    #110   +/-   ##
========================================
  Coverage      5.13%   5.13%           
  Complexity      158     158           
========================================
  Files            29      29           
  Lines           487     487           
========================================
  Hits             25      25           
  Misses          462     462           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

composer.json Outdated
Comment on lines 25 to 26
"symfony/http-foundation": "^4.4 || ^5.0.7",
"symfony/http-kernel": "^4.4 || ^5.1.5",
"symfony/http-kernel": "^4.4 || ^5.1.5 || ^6.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change both of these to ^5.4 || ^6.0? Thanks

I must have forgotten them on the recent update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Fix "symfony/http-foundation" & "symfony/http-kernel" requirements
@loevgaard loevgaard merged commit cffed86 into Setono:master Mar 27, 2023
@loevgaard
Copy link
Member

Thank you, @JordiDekker 🎉

It has been released :)

@JordiDekker JordiDekker deleted the JordiDekker-patch-1 branch March 27, 2023 08:56
@JordiDekker
Copy link
Contributor Author

Thanks @loevgaard 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants