Fix the bug in autograd example that sends wrong gradient backwards when computation graph doesn't resemble a tree #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhlich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://leetcode.com/playground/UPrmL2r9. In this example e = 24a+3 and the gradient should be 24 instead of 28.
The issue is that when a
NumberWithGradobject serves as the parent node of multiple operations, we just want to send the incoming gradientbackward_gradrecursively. The gradient ofbis 1 from pathb->c->e, and it's 5 from pathb->d->e. We send gradient 1 toafor the first time and send gradient1+5=6for the second time, and that's why we see 28