Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import interfaces and lib utils from set-protocol-v2 [SIM-124] #22

Merged
merged 7 commits into from
Mar 25, 2022
Merged

Import interfaces and lib utils from set-protocol-v2 [SIM-124] #22

merged 7 commits into from
Mar 25, 2022

Conversation

cgewecke
Copy link
Contributor

@cgewecke cgewecke commented Mar 17, 2022 •
edited
Loading

  • Removes interfaces, lib utils, mocks and related tests for contracts copied over for set-protocol-v2
  • Updates Solidity import statements to pull required contracts from the set-protocol-v2 npm package

TODO

  • Use @hardhat package published when set-protocol-v2 PR 203 is merged
  • Get build & tests runnning
  • Make sure all imports are alphabetized

Requires

@cgewecke cgewecke changed the title Import interfaces and lib utils from set-protocol-v2 Import interfaces and lib utils from set-protocol-v2 [SIM-24] Mar 17, 2022
@cgewecke cgewecke changed the title Import interfaces and lib utils from set-protocol-v2 [SIM-24] Import interfaces and lib utils from set-protocol-v2 Mar 17, 2022
@cgewecke cgewecke changed the title Import interfaces and lib utils from set-protocol-v2 Import interfaces and lib utils from set-protocol-v2 [SIM-124] Mar 17, 2022
This was referenced Mar 18, 2022
Merged
Merged
Merged
@cgewecke cgewecke force-pushed the chris/remove-root-protocol-contracts branch from 19d116a to a86b961 Compare March 24, 2022 23:02
@cgewecke cgewecke changed the base branch from master to chris/use-auto-published-contracts March 24, 2022 23:03
@cgewecke cgewecke force-pushed the chris/use-auto-published-contracts branch from 1e95d5b to 56d2c77 Compare March 25, 2022 20:49
Base automatically changed from chris/use-auto-published-contracts to master March 25, 2022 23:04
@cgewecke cgewecke force-pushed the chris/remove-root-protocol-contracts branch from 55afce0 to 66e8117 Compare March 25, 2022 23:15
@cgewecke cgewecke merged commit ced99fd into master Mar 25, 2022
@cgewecke cgewecke deleted the chris/remove-root-protocol-contracts branch March 25, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bweick bweick bweick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgewecke @bweick