Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synbols' docker break when there is a space in the installation path #30

Closed
recursix opened this issue Jan 14, 2021 · 4 comments · Fixed by #31
Closed

Synbols' docker break when there is a space in the installation path #30

recursix opened this issue Jan 14, 2021 · 4 comments · Fixed by #31
Assignees
@aldro61
Labels
bug Something isn't working

Comments

@recursix
Copy link
Collaborator

to reproduce:
git clone synbols in a directory that contains a space
pip install -e /synbols
@aldro61 aldro61 self-assigned this Jan 14, 2021
@aldro61 aldro61 added the bug Something isn't working label Jan 14, 2021
@aldro61
Copy link
Collaborator

aldro61 commented Jan 14, 2021 •
edited
Loading

@recursix I tried moving my synbols directory to synbols space to test and it still works. However, I cd synbols\ space and then pip install -e ., not pip install -e /synbols.

Screen Shot

So for the moment I cannot reproduce your issue. Can you post a screenshot of the error?

@aldro61
Copy link
Collaborator

aldro61 commented Jan 14, 2021

Ok I can reproduce the issue when using synbols-datasets
Screen Shot

@aldro61
Copy link
Collaborator

aldro61 commented Jan 14, 2021

Simple fix is to add single quotes around file here https://github.com/ElementAI/synbols/blob/master/synbols/entrypoints/run_docker.py#L94

aldro61 added a commit that referenced this issue Jan 14, 2021
@aldro61
Add quotes around file path to fix issue #30
e6d168a
@recursix
Copy link
Collaborator Author

LGTM

@aldro61 aldro61 linked a pull request Jan 14, 2021 that will close this issue
Fix issue #30 #31
Merged
recursix added a commit that referenced this issue Jan 14, 2021
@recursix
Merge pull request #31 from ElementAI/issue_30
045455a 
Fix issue #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aldro61 aldro61

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #30 ServiceNow/synbols
2 participants
@aldro61 @recursix