-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New locale for id-ID (Bahasa Indonesia) #431
Conversation
This is good. Do not you have holydays? Can you also add your language into |
@Serhioromano - Updated holidays list for id-ID locale :) Please check. |
|
||
first_day: 1, | ||
holidays: { | ||
/* for 2015 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all those holidays will be only in 2015 and not in 2014?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Serhioromano - Yes, those holidays are using islamic calendar system, so each date from those holidays will be different each year. I'll update holidays for 2016 later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell me more about those holidays. How days are detected? Is it first day of the first week of the month or is it every monday of the second week? What are rules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very sure how to detect and rules for those date. But from what i read on many online resources, islamic calendar using astronomical calculations.
"The Islamic calendar is not to be confused with a lunar calendar that is based on astronomical calculations. The latter is based on a year of 12 months adding up to 354.37 days. Each lunar month begins at the time of the monthly "conjunction", when the Moon is located on a straight line between the Earth and the Sun."
The following url might be very helpful about this information : http://en.wikipedia.org/wiki/Islamic_calendar
New locale for id-ID (Bahasa Indonesia)
I see. Thank you for contribution. |
Hi @Serhioromano - do you mind to take a look for this new locale?