Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's use GET instead of POST to get events #35

Merged
merged 2 commits into from
Aug 9, 2013
Merged

Let's use GET instead of POST to get events #35

merged 2 commits into from
Aug 9, 2013

Conversation

mlocati
Copy link
Contributor

@mlocati mlocati commented Aug 8, 2013

Let's use the GET method to get data.

Furthermore, I removed $.ajaxSetup since:

  • it may affect other scripts in the page
  • other scripts in the page could call $.ajaxSetup, so we can't trust this approach

@mlocati mlocati mentioned this pull request Aug 8, 2013
@mlocati
Copy link
Contributor Author

mlocati commented Aug 9, 2013

@Serhioromano I leave to you the generation of calendar.min.js, so you do not get bored by just pressing that big green button 😉

Serhioromano added a commit that referenced this pull request Aug 9, 2013
Let's use GET instead of POST to get events
@Serhioromano Serhioromano merged commit f57305d into Serhioromano:master Aug 9, 2013
@Serhioromano
Copy link
Owner

I will never get bored of that. Especially if those PRs goes from you @mlocati.

Thank you once more! Excellent job. And closed #34

@mlocati mlocati deleted the get-with-get branch August 9, 2013 07:41
@mlocati
Copy link
Contributor Author

mlocati commented Aug 9, 2013

Thank you to you, Sergey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants