Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add WDM_SSL_VERIFY env property #253

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

aleksandr-kotlyar
Copy link
Collaborator

@aleksandr-kotlyar aleksandr-kotlyar commented Oct 19, 2021

Details: added WDM_SSL_VERIFY env property to disable requests ssl verification (feature to fix issues #219, #226)

  • covered with tests
  • updated CHANGELOG
  • updated README

Closes #219
Closes #226

Details: add WDM_SSL_VERIFY env property to disable requests ssl verification (feature to fix issues SergeyPirogov#219, SergeyPirogov#226)
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #253 (4b8e6eb) into master (7e92270) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   88.17%   88.19%   +0.02%     
==========================================
  Files          11       11              
  Lines         465      466       +1     
  Branches       52       52              
==========================================
+ Hits          410      411       +1     
  Misses         37       37              
  Partials       18       18              
Impacted Files Coverage Δ
webdriver_manager/driver.py 95.83% <100.00%> (+0.02%) ⬆️
webdriver_manager/manager.py 100.00% <100.00%> (ø)
webdriver_manager/utils.py 74.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e92270...4b8e6eb. Read the comment docs.

@SergeyPirogov SergeyPirogov merged commit 17384a3 into SergeyPirogov:master Oct 19, 2021
aleksandr-kotlyar added a commit to aleksandr-kotlyar/webdriver_manager that referenced this pull request Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to install chrome driver failed to install geckodriver
3 participants